Add template for prereleases#9165
Conversation
|
Hi @king-alexander, From #8820 I take we also need to update |
|
Hey @nicoddemus! I appreciate your comment. I'm new to open source and using Hacktoberfest as an opportunity to get more involved. Yes, |
|
No worries, take your time, and let us know if you have any questions! |
|
Hey @nicoddemus thanks! I do have a question. Under what condition should the prerelease template be used versus the minor release template or patch template? @The-Compiler mentions passing the is_major option to release.py, but don't we need another condition to pick between 3 different templates? |
At the moment Line 13 in e84ba80 And based on that, decides which template to use: Lines 25 to 27 in e84ba80 I suggest we explicitly pass the name of template, so pytest/scripts/prepare-release-pr.py Line 85 in e84ba80 |
|
@nicoddemus Let me know what you think! |
nicoddemus
left a comment
There was a problem hiding this comment.
Thanks @king-alexander for the updates, left a few more comments, please take a look!
Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>
for more information, see https://pre-commit.ci
Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>
|
Thank you @nicoddemus! I'm grateful for the chance to contribute 🙂 |
|
@nicoddemus Is this good to merge? |
|
Yes, thanks for the ping! Merging. |
|
Just catching up on pytest 7.0.0 in the last couple of days - thanks @king-alexander and @nicoddemus, great work! 👍 |
Close #8820