Skip to content

Conversation

@Kojoley
Copy link

@Kojoley Kojoley commented Nov 11, 2021

Only suppress deprecation types that are passed in expected_warning argument.

Fixes #9288

Looking for a feedback, are you ok with this change?

Only suppress deprecations explicitly stated in `expected_warning` argument.
@Kojoley Kojoley force-pushed the warns-dont-suppress-deprecations branch from 48b4204 to 2e928ce Compare May 30, 2023 18:15
@Kojoley Kojoley changed the title Don't always suppress deprecation warnings in pytest.warns Reemit deprecation warnings from pytest.warns May 30, 2023
@Kojoley Kojoley marked this pull request as ready for review May 30, 2023 18:35
@Zac-HD
Copy link
Member

Zac-HD commented Jun 20, 2023

Let's go with the more general solution in #10937.

@Zac-HD Zac-HD closed this Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document that with pytest.warns() captures all warnings, not just those it tests were emitted

2 participants