Change deprecation warnings into errors for 7.0 release, using a new mechanism#9309
Merged
bluetech merged 2 commits intopytest-dev:mainfrom Nov 21, 2021
Merged
Conversation
Closes pytest-dev#7480. This allows us to more easily follow our deprecation policy of turning warnings into errors for the X.0 releases before complete removal in X.1. It also makes the deprecation timeline clear to both the users and pytest developers -- it can be hard to keep track. Note that the designation is not meant to be a binding contract - if the time comes for removal of a specific deprecation but we decide it's too soon, can just bump it to the next major. Inspired by Django: https://docs.djangoproject.com/en/dev/internals/contributing/writing-code/submitting-patches/#deprecating-a-feature
Per our backward compatibility policy. Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>
nicoddemus
approved these changes
Nov 19, 2021
Member
nicoddemus
left a comment
nicoddemus
left a comment
There was a problem hiding this comment.
Looks great, thanks for tackling this!
The-Compiler
added a commit
to The-Compiler/pytest
that referenced
this pull request
Nov 24, 2021
Follow-up to pytest-dev#9309. The issue in the changelog broke the docs build with: doc/en/_changelog_towncrier_draft.rst:47: WARNING: Inline literal start-string without end-string. The second change isn't as critical, but caused the text to be rendered as monospace including the tilde (i.e. `~pytest.PytestDeprecationwarning`).
Member
|
This breaks the |
The-Compiler
added a commit
that referenced
this pull request
Nov 25, 2021
Follow-up to #9309. The issue in the changelog broke the docs build with: doc/en/_changelog_towncrier_draft.rst:47: WARNING: Inline literal start-string without end-string. The second change isn't as critical, but caused the text to be rendered as monospace including the tilde (i.e. `~pytest.PytestDeprecationwarning`).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #9308. The first attempt #8837 ran into trouble because some deprecations weren't ready for removal. I make things work by adding
PytestRemovedInXwarnings. Please see the commit messages for more details.The reason I worked on this is I'm eager to remove one deprecation - the
FILLFUNCARGS- and don't want to wait until pytest 8.1 for that :)