Conversation
The-Compiler
left a comment
The-Compiler
left a comment
There was a problem hiding this comment.
Looks like we have one bigger and a couple of minor issues remaining.
| $ pytest --fixtures -v | ||
| =========================== test session starts ============================ | ||
| platform linux -- Python 3.x.y, pytest-6.x.y, py-1.x.y, pluggy-1.x.y -- $PYTHON_PREFIX/bin/python | ||
| platform linux -- Python 3.x.y, pytest-7.x.y, pluggy-1.x.y -- $PYTHON_PREFIX/bin/python |
There was a problem hiding this comment.
Is it intended that we don't show the py version here anymore?
There was a problem hiding this comment.
i think that was path of the phase out,
| * denivyruck | ||
| * ericluoliu | ||
| * oleg.hoefling | ||
| * pytest bot |
| $ pytest -E stage2 | ||
| =========================== test session starts ============================ | ||
| platform linux -- Python 3.x.y, pytest-6.x.y, py-1.x.y, pluggy-1.x.y | ||
| cachedir: .pytest_cache |
There was a problem hiding this comment.
huh, why did this disappear? But ok I guess...
| ========================= short test summary info ========================== | ||
| FAILED test_simple.yaml::hello | ||
| ======================= 1 failed, 1 passed in 0.12s ======================== | ||
| Traceback (most recent call last): |
There was a problem hiding this comment.
Whoops, looks like @nicoddemus missed that one... #9373
| SKIPPED [9] multipython.py:29: 'python3.5' not found | ||
| SKIPPED [9] multipython.py:29: 'python3.6' not found | ||
| SKIPPED [9] multipython.py:29: 'python3.7' not found | ||
| 27 skipped in 0.12s |
There was a problem hiding this comment.
Hmmm, this output doesn't really show what we wanted to show there. Not sure what to do about that?
There was a problem hiding this comment.
No I think showing a few skips is fine. I wouldn't worry about it.
There was a problem hiding this comment.
we could jsut run setup-python for all pythons we need, sometime later
There was a problem hiding this comment.
We say:
Running it results in some skips if we don't have all the python interpreters installed and otherwise runs all combinations (3 interpreters times 3 interpreters times 3 objects to serialize/deserialize):
but I guess "all skipped" is an alright demo of "some skips" 😆
|
How do I best update this with the last fixes from main now? Close PR, delete 7.0.x branch, recreate branch on latest main, trigger release again? |
Yes I think that's the simplest way to do it. 👍 |
4 participants
Created automatically from manual trigger.
Once all builds pass and it has been approved by one or more maintainers, the build
can be released by pushing a tag
7.0.0rc1to this repository.