code: accept any os.PathLike[str] in Traceback.cut#9447
Merged
bluetech merged 1 commit intopytest-dev:mainfrom Dec 27, 2021
Merged
code: accept any os.PathLike[str] in Traceback.cut#9447bluetech merged 1 commit intopytest-dev:mainfrom
os.PathLike[str] in Traceback.cut#9447bluetech merged 1 commit intopytest-dev:mainfrom
Conversation
Before 7.0.0rc1, the function accepted `Union[str, py.path.local]`, and `py.path.local` compares equal to the string path, so a user was able to pass the path as a string and it would work. In 7.0.0rc1 we changed the `py.path.local` to `Path` which doesn't compare equal to the string path, which breaks compatibility (e.g. the `sybil` package). This restores compatibility for this function by accepting any `os.PathLike[str]` and only comparing the string representations.
bluetech
added
the
needs backport
nicoddemus
approved these changes
Dec 27, 2021
bluetech
added a commit
to bluetech/pytest
that referenced
this pull request
Dec 27, 2021
code: accept any `os.PathLike[str]` in `Traceback.cut` (cherry picked from commit fcef7e4)
The-Compiler
added
backported
and removed
needs backport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is extracted from/alternative to #9440 which keeps the breaking change for the
pathproperties but fixes this particular compat issue.Before 7.0.0rc1, the function accepted
Union[str, py.path.local], andpy.path.localcompares equal to the string path, so a user was able topass the path as a string and it would work. In 7.0.0rc1 we changed the
py.path.localtoPathwhich doesn't compare equal to the stringpath, which breaks compatibility (e.g. the
sybilpackage).This restores compatibility for this function by accepting any
os.PathLike[str]and only comparing the string representations.