Merged
Conversation
nicoddemus
requested changes
Apr 22, 2022
Member
nicoddemus
left a comment
There was a problem hiding this comment.
Thanks @Zac-HD!
We should also update the description of log_file in reference.rst, it is incorrect in there as well.
Co-authored-by: Bruno Oliveira <nicoddemus@gmail.com>
Member
Author
This PR does update |
Member
|
Oh I could sworn it was updating only |
nicoddemus
approved these changes
Apr 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a relative path is passed for the
--log-fileCLI argument, or thelog_fileconfig option is set, it is always resolved relative to the current working directory - pytest doesn't have any special logic beyond that in the standard librarylogging.FileHandler.Unfortunately this was incorrectly documented as being relative to the
pytest.inifile (not rootdir), which kicked off a considerable chain of confusion. This PR therefore fixes #7336, closes #7350, and closes #9700.Any proposal to change the current internally-consistent behaviour should start from a fresh issue, and include a description of why the alternative semantics are more desirable, and how to manage the backwards-compatibility implications of moving so many users' log files.