Skip to content

feat: introduce created_at to distinguish between generated backups #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ethicnology wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: introduce created_at to distinguish between generated backups #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a213f7
fix: add missing field version and description and remove version fro…
ethicnology Aug 25, 2025
3ee75b0
feat: add optional `created_at` field to Backup struct and update README
ethicnology Aug 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ JSON object representing the backup structure. This object includes wallet-level
metadata, multiple accounts, and associated key data.

### Wallet Backup Structure

- `created_at`: Optional timestamp indicating the backup creation time
- `version`: Optionnal version of the backup format
- `name`: Optional wallet name
- `description`: Optional wallet description
Expand Down
12 changes: 9 additions & 3 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,14 @@ use serde::{Deserialize, Serialize};

#[derive(Debug, Serialize, Deserialize)]
pub struct Backup {
#[serde(skip_serializing_if = "Option::is_none")]
pub created_at: Option<u64>,
#[serde(skip_serializing_if = "Option::is_none")]
pub version: Option<u32>,
#[serde(skip_serializing_if = "Option::is_none")]
pub name: Option<String>,
#[serde(skip_serializing_if = "Option::is_none")]
pub description: Option<String>,
pub accounts: Vec<Account>,
pub network: Network,
/// App proprietary metadata (settings, configuration, etc..)
Expand All @@ -17,10 +23,10 @@ pub struct Backup {

#[derive(Debug, Serialize, Deserialize)]
pub struct Account {
#[serde(skip_serializing_if = "Option::is_none")]
pub version: Option<u32>,
#[serde(skip_serializing_if = "Option::is_none")]
pub name: Option<String>,
#[serde(skip_serializing_if = "Option::is_none")]
pub description: Option<String>,
pub descriptor: miniscript::Descriptor<miniscript::DescriptorPublicKey>,
pub active: bool,
pub receive_index: Option<u64>,
Expand All @@ -44,8 +50,8 @@ pub struct Account {
impl Account {
pub fn new(descriptor: miniscript::Descriptor<miniscript::DescriptorPublicKey>) -> Self {
Self {
version: None,
name: None,
description: None,
descriptor,
active: true,
receive_index: None,
Expand Down