Some refactoring#2
Merged
sarusso merged 2 commits intopythings:masterfrom Feb 19, 2020
Merged
Conversation
In order to lower the memory footprint of this module, let's deliberately move the usage example code into a separate file.
Before defining a custom logger class which always will print to STDOUT/UART, let's try to use Python's native logging module.
Collaborator
|
Very interesting the integration you are working on. Thanks for the PR! You kind of beaten me on time :) p.s. I am going to switch to a git flow-ish branching model with master and develop public branches, and probably to do some refactoring on my side (i.e. a folder for each driver). Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Stefano,
while working on the integration of your SIM800 driver into our Terkin datalogger [1,2], we made the changes included within this PR.
Thanks again and with kind regards,
Andreas.
[1] https://community.hiveeyes.org/t/unlocking-and-improving-the-pythings-sim800-gprs-module-for-micropython/2978
[2] hiveeyes/terkin-datalogger@f3f892b