Skip to content

Config layer suggestion with registry#14

Draft
TeresiaOlsson wants to merge 3 commits intodev/mainfrom
dev/feature/config-layer
Draft

Config layer suggestion with registry#14
TeresiaOlsson wants to merge 3 commits intodev/mainfrom
dev/feature/config-layer

Conversation

@TeresiaOlsson
Copy link

@TeresiaOlsson TeresiaOlsson commented Nov 13, 2025

I have added the type of functionality I would like to have where you can generate the configuration in a modular way using the config classes directly and then create a registry object to browse and change the configuration. I have called the registry class for Accelerator to make it easier for MML users to understand since it corresponds to the functionality of the AcceleratorObject in MML and contains all the information about the accelerator.

I don't understand what is done with FileRepository in the ConfigService so I didn't dare to change anything there but my idea is that both ConfigService and the YellowPages should be replaced by something like this.

The idea would then be that when generating the devices, the required config data should be extracted from the Accelerator and there would be a factory which creates either TANGO or EPICS devices based on the control system config.

I also made some suggestion to changes for the devices because I think some of the names are not easy for most people to understand but I think more work is required to come up with good data models for devices.

@TeresiaOlsson TeresiaOlsson marked this pull request as draft November 13, 2025 18:07
@TeresiaOlsson
Copy link
Author

I commented out the PowerConverterInterface and PowerConverter because I don't think they are sufficiently generic data models for both TANGO and EPICS. The ResponseModel I think also applies to more devices than just power supplies and other settable devices. Also diagnostic devices (like the tune device) need some time to settle before you read the device.

@Sulimankhail
Copy link
Contributor

@copilot add your review

Copy link
Contributor

Copilot AI commented Nov 14, 2025

@Sulimankhail I've opened a new pull request, #15, to work on those changes. Once the pull request is ready, I'll request review from you.

…ub-pr-14

Add code review for config layer and registry implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants