Merged
Conversation
for more information, see https://pre-commit.ci
Added a new TypeVar '_U' bound to UnionType for type validation.
Contributor
Author
|
I believe that I need to add some mypy tests to adequately verify that or_ works the way that I believe it does. However, it's unclear where I should add that. |
Member
That would go to tests/typing_example.py – just exercise the types (it doesn't have to be runnable) – thanks! |
Member
|
So I can't make this fail on Mypy… maybe its plugin somehow works around this? Have you had any failures somehow somewhere? |
Member
|
OK, this fails on Pyright: @attrs.define
class ValidatedInconsistenOr:
num: int = attrs.field(
validator=attrs.validators.or_(
# Various types of validators.
attrs.validators.ge(0),
attrs.validators.instance_of(object),
)
)I'll split up the type hints a bit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The type hinting for the or_ function presumes that all validators used have the same input type though that is not a requirement. This adds several overloads and a fall-through Any type catch-all to the or_ function that will help satisfy the type check.
Pull Request Check List
mainbranch – use a separate branch!Our CI fails if coverage is not 100%.
.pyi).tests/typing_example.py.attr/__init__.pyi, they've also been re-imported inattrs/__init__.pyi.docs/api.rstby hand.@attr.s()and@attrs.define()have to be added by hand too.versionadded,versionchanged, ordeprecateddirectives.The next version is the second number in the current release + 1.
The first number represents the current year.
So if the current version on PyPI is 22.2.0, the next version is gonna be 22.3.0.
If the next version is the first in the new year, it'll be 23.1.0.
attrs.define()andattr.s(), you have to add version directives to both..rstand.mdfiles is written using semantic newlines.changelog.d.