WIP: Add an auto-converter, converters and validators#701
WIP: Add an auto-converter, converters and validators#701sscherfke wants to merge 1 commit intopython-attrs:masterfrom
Conversation
|
This is PR is based on #653 and adds actual converters and validators for attrs classes. These should be complete enough to cover most use cases for API clients and settings loaders. The current state of the PR should be functionally complete, but some docs are still missing. I will be available for help if bugs or issues should arrise with the code of this PR. |
|
@hynek What do you generally think about this PR? Shall I continue working on it? |
|
Hmmm I think this would be better served as an external proof of concept before we bake it into attrs? |
|
I could put it into typed-settings for a while. From there I could also use it for some API clients. Should this PR remain open? |
|
We should have a place to regularly touch base but maybe your original ticket is better for that, since it has more history? |
|
Okay, let's do that. I’ll create a new PR once you think these changes are ready to be integrated into attrs. |
Fixes: #649
Pull Request Check List
This is just a friendly reminder about the most common mistakes. Please make sure that you tick all boxes. But please read our contribution guide at least once, it will save you unnecessary review cycles!
If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing left to do. If your pull request is a documentation fix or a trivial typo, feel free to delete the whole thing.
.pyi).tests/typing_example.py.docs/api.rstby hand.@attr.s()have to be added by hand too.versionadded,versionchanged, ordeprecateddirectives. Find the appropriate next version in our__init__.pyfile..rstfiles is written using semantic newlines.changelog.d.If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!