Skip to content

Fix inconsistent tuple/typing.Tuple unstructuring #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tinche merged 4 commits into from
Mar 20, 2022
Merged

Fix inconsistent tuple/typing.Tuple unstructuring #227

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
341e50f
Add forgotten Tuple check to is_sequence
bibajz Feb 8, 2022
ba07612
Unstructure heterogenous tuples to list by default
bibajz Feb 8, 2022
73054da
Add HISTORY.rst entry
bibajz Feb 8, 2022
158d9d3
Merge branch 'main' into bibajz/tuple_unstructuring
Tinche Mar 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ History
(`#217 <https://github.com/python-attrs/cattrs/issues/217>`_)
* Fix structuring of ``enum.Enum`` instances in ``typing.Literal`` types.
(`#231 <https://github.com/python-attrs/cattrs/pull/231>`_)
* Fix unstructuring all tuples - unannotated, variable-length, homogenous and heterogenous - to `list`.
(`#226 <https://github.com/python-attrs/cattrs/issues/226>`_)


1.10.0 (2022-01-04)
-------------------
Expand Down
1 change: 1 addition & 0 deletions src/cattr/_compat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,7 @@ def is_sequence(type: Any) -> bool:
TypingSequence,
TypingMutableSequence,
AbcMutableSequence,
Tuple,
tuple,
)
or (
Expand Down
2 changes: 1 addition & 1 deletion src/cattr/converters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -773,7 +773,7 @@ def gen_unstructure_iterable(self, cl: Any, unstructure_to=None):

def gen_unstructure_hetero_tuple(self, cl: Any, unstructure_to=None):
unstructure_to = self._unstruct_collection_overrides.get(
get_origin(cl) or cl, unstructure_to or tuple
get_origin(cl) or cl, unstructure_to or list
)
h = make_hetero_tuple_unstructure_fn(cl, self, unstructure_to=unstructure_to)
self._unstructure_func.register_cls_list([(cl, h)], direct=True)
Expand Down