Skip to content

Don't try to upload coverage if CI is run via workflow dispatch on a fork#385

Merged
Tinche merged 1 commit into
python-attrs:mainfrom
AlexWaygood:workflow-dispatch
Jun 13, 2023
Merged

Don't try to upload coverage if CI is run via workflow dispatch on a fork#385
Tinche merged 1 commit into
python-attrs:mainfrom
AlexWaygood:workflow-dispatch

Conversation

@AlexWaygood
Copy link
Copy Markdown
Contributor

While investigating python/typing_extensions#230 and preparing #384, I tried running cattrs's CI on my fork via workflow-dispatch. This was made a little more complicated by the fact that the "upload coverage to codecov" step always seems to fail when the workflow is run on a fork

@Tinche
Copy link
Copy Markdown
Member

Tinche commented Jun 13, 2023

Thanks! I want to get rid of codecov long-term but still looking for a good alternative.

@Tinche Tinche merged commit 4ad09bc into python-attrs:main Jun 13, 2023
@AlexWaygood AlexWaygood deleted the workflow-dispatch branch June 13, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants