Skip to content

Fix type resolution#662

Merged
Tinche merged 11 commits into
python-attrs:mainfrom
AdrianSosic:fix/type_resolution
Jun 27, 2025
Merged

Fix type resolution#662
Tinche merged 11 commits into
python-attrs:mainfrom
AdrianSosic:fix/type_resolution

Conversation

@AdrianSosic
Copy link
Copy Markdown
Contributor

Fixes #661

@AdrianSosic AdrianSosic force-pushed the fix/type_resolution branch from 58ee5ae to 05d823b Compare June 26, 2025 10:56
Comment thread tests/test_generics.py Outdated
Comment thread src/cattrs/converters.py
@Tinche Tinche self-requested a review June 26, 2025 11:16
Copy link
Copy Markdown
Member

@Tinche Tinche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a small changelog entry.

Comment thread tests/test_generics.py Outdated
Comment thread tests/test_generics.py Outdated
Comment thread tests/test_generics.py Outdated
Comment thread HISTORY.md Outdated
@Tinche Tinche self-requested a review June 26, 2025 14:55
Copy link
Copy Markdown
Member

@Tinche Tinche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please rename forwardrefs.py to something else, and add a period (.) to the end of the changelog entry ;)

Comment thread HISTORY.md Outdated
Comment thread tests/generics.py Outdated
@AdrianSosic AdrianSosic force-pushed the fix/type_resolution branch from c5795ad to 414799b Compare June 27, 2025 08:01
@AdrianSosic AdrianSosic requested a review from Tinche June 27, 2025 08:30
Copy link
Copy Markdown
Member

@Tinche Tinche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ as usual

@Tinche Tinche merged commit 30fb43e into python-attrs:main Jun 27, 2025
11 checks passed
@AdrianSosic AdrianSosic deleted the fix/type_resolution branch June 27, 2025 08:39
AdrianSosic added a commit to emdgroup/baybe that referenced this pull request Jul 2, 2025
AdrianSosic added a commit to emdgroup/baybe that referenced this pull request Jul 2, 2025
AdrianSosic added a commit to emdgroup/baybe that referenced this pull request Jul 22, 2025
AdrianSosic added a commit to emdgroup/baybe that referenced this pull request Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unresolved generic types

2 participants