Refactoring search and filters #563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 14, 2025
…g matches. So the default operator should not be == but 'contains'
…ch of icalendar-searcher)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
calendar.search-method takes tons and tons of various parameters, and many special cases in the search method makes it desirable to make recursive calls - which again is very cumbersome when there are too many parameters to keep track of.I decided to split out the search logic into a separate file
search.py, create a new classComponentSearcherthat can hold most of the search-related parameters. I've also tried to make some logical separation between search filters referencing the icalendar properties, other search filters and search options, as well as the caldav-specific search options.I do hope that this separation makes the code flow easier to understand and more flexible to adapt and develop. I do have plans both for client-side filtering, searching and accessing servers that doesn't speak caldav and much else.