Skip to content

Conversation

@tleonhardt
Copy link
Member

@tleonhardt tleonhardt commented Apr 10, 2018

Deleted optparse code which had been previously deprecated in 0.8.0 release

Also:

  • Bumped version to 0.9.0

This ended up being a larger change than I thought it would be at first mostly due to the fact that I forgot we had a bunch of unit tests that we had never ported to use the new decorators.

This closes #340

@tleonhardt tleonhardt added this to the 0.8.4 milestone Apr 10, 2018
@tleonhardt tleonhardt self-assigned this Apr 10, 2018
@tleonhardt tleonhardt requested review from kmvanbrunt and kotfu April 10, 2018 05:19
('dotstar.txt', False),
('extension_notation.txt', False),
('from_cmdloop.txt', True),
# ('from_cmdloop.txt', True),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kotfu I couldn't quickly figure out what was going wrong with these two unit tests here so I commented them out. If you can figure it out without too much effort, then please go ahead and fix them.

@codecov
Copy link

codecov bot commented Apr 10, 2018

Codecov Report

Merging #344 into master will decrease coverage by 0.34%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #344      +/-   ##
==========================================
- Coverage    89.6%   89.26%   -0.35%     
==========================================
  Files           1        1              
  Lines        1982     1909      -73     
==========================================
- Hits         1776     1704      -72     
+ Misses        206      205       -1
Impacted Files Coverage Δ
cmd2.py 89.26% <100%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4c6cd4...339d2ef. Read the comment docs.

Todd Leonhardt added 2 commits April 10, 2018 10:27
@tleonhardt tleonhardt modified the milestones: 0.8.4, 0.8.5 Apr 10, 2018
@tleonhardt tleonhardt modified the milestones: 0.8.5, 0.9.0 Apr 12, 2018
@tleonhardt
Copy link
Member Author

tleonhardt commented Apr 14, 2018

This will end up being the first PR or so to go into the 0.9.0 cycle, but we can't merge it in until after we put out the 0.8.5 release as well as create a python2 branch and tag. Then we will need to merge stuff in here and update.

Also:
- Bumped version to 0.9.0
@tleonhardt
Copy link
Member Author

The 0.8.5 changes have been merged in from master and the version in this PR has been bumped to 0.9.0.

@tleonhardt tleonhardt merged commit 8aaf6f4 into master Apr 15, 2018
@tleonhardt tleonhardt deleted the delete_optparse branch April 15, 2018 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delete deprecated optparse code

2 participants