-
Notifications
You must be signed in to change notification settings - Fork 127
Delete optparse #344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete optparse #344
Conversation
…elease Also: - Bumped version to 0.8.4
| ('dotstar.txt', False), | ||
| ('extension_notation.txt', False), | ||
| ('from_cmdloop.txt', True), | ||
| # ('from_cmdloop.txt', True), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kotfu I couldn't quickly figure out what was going wrong with these two unit tests here so I commented them out. If you can figure it out without too much effort, then please go ahead and fix them.
Codecov Report
@@ Coverage Diff @@
## master #344 +/- ##
==========================================
- Coverage 89.6% 89.26% -0.35%
==========================================
Files 1 1
Lines 1982 1909 -73
==========================================
- Hits 1776 1704 -72
+ Misses 206 205 -1
Continue to review full report at Codecov.
|
# Conflicts: # CHANGELOG.md
# Conflicts: # cmd2.py
|
This will end up being the first PR or so to go into the 0.9.0 cycle, but we can't merge it in until after we put out the 0.8.5 release as well as create a python2 branch and tag. Then we will need to merge stuff in here and update. |
Also: - Bumped version to 0.9.0
|
The 0.8.5 changes have been merged in from master and the version in this PR has been bumped to 0.9.0. |
Deleted optparse code which had been previously deprecated in 0.8.0 release
Also:
This ended up being a larger change than I thought it would be at first mostly due to the fact that I forgot we had a bunch of unit tests that we had never ported to use the new decorators.
This closes #340