-
Notifications
You must be signed in to change notification settings - Fork 127
Move to Python 3.4+ only #354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mock was a backport of Python's built in unittest.mock and was required for Python 3.2 or earlier - Since we now support Python 3.4+ moving forward we no longer need to make use of the 3rd party mock module
Apparently there were some issues in the unitest.mock module in Python 3.5 (but not 3.4 or 3.6)
Removed all dependency on six other than for six.moves.input Also: - Started removing code branches which were for Python 2 support
Codecov Report
@@ Coverage Diff @@
## master #354 +/- ##
==========================================
+ Coverage 89.26% 89.31% +0.05%
==========================================
Files 1 1
Lines 1909 1872 -37
==========================================
- Hits 1704 1672 -32
+ Misses 205 200 -5
Continue to review full report at Codecov.
|
This is to support installation from package managers on older OSes such as Debian 9.
|
I'm going to go ahead and merge this. We can clean up and/or change in future PRs if need be. But future work will depend on this, so I'm going to merge it in. |
cmd2now supports Python 3.4+ only for versions starting with 0.9.0. This PR starts removing support for Python 2.7 and begins cleaning up things which are no longer needed.Changes include:
mockmodule is now only used for tests on Python 3.5sixmoduleThis closes #260