Started adding type hints #363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #363 +/- ##
==========================================
- Coverage 91.24% 91.23% -0.01%
==========================================
Files 3 3
Lines 2273 2271 -2
==========================================
- Hits 2074 2072 -2
Misses 199 199
Continue to review full report at Codecov.
|
Contributor
|
Wow, I hope there was a script or PyCharm/Visual Studio Code function that did this automatically from the existing type hints in the comments. |
Member
Author
|
Unfortunately I did it manually. There are tools which will do it for you semi-automatically, but I didn't want to take the time to learn to use one of them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started adding optional type hinting.
This partially addresses #355.