Skip to content

Conversation

@anselor
Copy link
Contributor

@anselor anselor commented Apr 23, 2018

Enables support for using class methods of the Cmd2 application to decorate argparse argument's completion provider.

anselor added 3 commits April 23, 2018 15:19
… completion provider. The default completion implementation in Cmd2 automatically passes self to AutoCompleter to be passed to the class method.
@anselor anselor added this to the 0.9.0 milestone Apr 23, 2018
@anselor anselor requested a review from tleonhardt as a code owner April 23, 2018 19:27
@codecov
Copy link

codecov bot commented Apr 23, 2018

Codecov Report

Merging #367 into master will decrease coverage by 0.05%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #367      +/-   ##
==========================================
- Coverage    91.1%   91.04%   -0.06%     
==========================================
  Files           3        3              
  Lines        2236     2245       +9     
==========================================
+ Hits         2037     2044       +7     
- Misses        199      201       +2
Impacted Files Coverage Δ
cmd2/cmd2.py 90.97% <100%> (ø) ⬆️
cmd2/argparse_completer.py 90.88% <80%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9b676a...4bc454f. Read the comment docs.

@kmvanbrunt kmvanbrunt merged commit f11b063 into master Apr 23, 2018
@tleonhardt tleonhardt deleted the autocompleter branch April 26, 2018 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants