Bash completion #386
Merged
Bash completion #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting to stderr to bypass bash completion handling.
…ion logic in the argcomplete function but doesn't test actual completion in bash.
Codecov Report
@@ Coverage Diff @@
## master #386 +/- ##
==========================================
+ Coverage 87.74% 88.98% +1.23%
==========================================
Files 8 8
Lines 2751 2615 -136
==========================================
- Hits 2414 2327 -87
+ Misses 337 288 -49
Continue to review full report at Codecov.
|
tleonhardt
previously approved these changes
May 4, 2018
| outstr = ifs.join([filler, outstr]) | ||
|
|
||
| output_stream.write(outstr.encode(argcomplete.sys_encoding)) | ||
| comp_type = int(os.environ["COMP_TYPE"]) |
Member
There was a problem hiding this comment.
Strange. But if it works, cool.
Contributor
Author
There was a problem hiding this comment.
Yeah. The first tab press comes in as 9. Makes total sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Figured out how to detect which time the user pressed tab. Changed the argument hinting to print to stderr after the first tab.