Merged
Conversation
Also: - Refactored perror() to remove a rarely used optional argument which was unecessary
Codecov Report
@@ Coverage Diff @@
## master #440 +/- ##
==========================================
+ Coverage 90.26% 90.28% +0.02%
==========================================
Files 9 9
Lines 2721 2738 +17
==========================================
+ Hits 2456 2472 +16
- Misses 265 266 +1
Continue to review full report at Codecov.
|
Also: - Added a few more type hints
anselor
approved these changes
Jun 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working on improving type hinting
Also:
The initial type hinting is substantially complete - not 100%, but close to it. Also, the type hinting isn't perfect - I'm sure over time we will refine it after running more with something like mypy - but it is a good initial approximately correct set of types for function/method arguments and return values.
This closes #355.