Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #578 +/- ##
==========================================
+ Coverage 93.18% 93.19% +<.01%
==========================================
Files 11 11
Lines 3185 3188 +3
==========================================
+ Hits 2968 2971 +3
Misses 217 217
Continue to review full report at Codecov.
|
tleonhardt
requested changes
Oct 13, 2018
CHANGELOG.md
Outdated
| * All platforms now depend on [wcwidth](https://pypi.python.org/pypi/wcwidth) to assist with asynchronous alerts. | ||
| * Macros now accept extra arguments when called. These will be tacked onto the resolved command. | ||
| * All cmd2 commands run via py now go through onecmd_plus_hooks. | ||
| * Bug Fixes |
|
|
||
| def _exec_cmd(cmd2_app, func: Callable, echo: bool) -> CommandResult: | ||
| """Helper to encapsulate executing a command and capturing the results""" | ||
| def _exec_cmd(cmd2_app, command: str, echo: bool) -> CommandResult: |
tleonhardt
previously approved these changes
Oct 13, 2018
| @@ -1,7 +1,11 @@ | |||
| ## 0.9.6 (TBD) | |||
| ## 0.9.6 (October 13, 2018) | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.