Conversation
Codecov Report
@@ Coverage Diff @@
## master #627 +/- ##
==========================================
+ Coverage 93.2% 93.21% +<.01%
==========================================
Files 11 11
Lines 3194 3196 +2
==========================================
+ Hits 2977 2979 +2
Misses 217 217
Continue to review full report at Codecov.
|
| set_parser.add_argument('-l', '--long', action='store_true', help='describe function of parameter') | ||
| setattr(set_parser.add_argument('param', nargs='?', help='parameter to set or view'), | ||
| ACTION_ARG_CHOICES, settable) | ||
| ACTION_ARG_CHOICES, get_settable_names) |
| assert len(base_app.macros) == 2 | ||
| assert sorted(base_app.get_macro_names()) == ['bar', 'foo'] | ||
|
|
||
| def test_get_settable_names(base_app): |
There was a problem hiding this comment.
Thanks for adding a unit test
…d already sorts it results
…before calling init()
| @@ -1,3 +1,7 @@ | |||
| ## 0.9.9 (TBD, 2019) | |||
| * Bug Fixes | |||
There was a problem hiding this comment.
I'd recommend adding an Enhancement section and mentioning that self.settable can now be modified at an arbitrary time and is no loner restricted to being modified prior to calling super.__init__().
There was a problem hiding this comment.
This was always possible, I just updated the examples to reflect it.
| super().__init__(use_ipython=False) | ||
|
|
||
| # Make maxrepeats settable at runtime | ||
| self.settable['maxrepeats'] = 'max repetitions for speak command' |
There was a problem hiding this comment.
Consider adding a unit test to validate that self.settable can be mutated either before or after calling super.__init__().
There was a problem hiding this comment.
This was always possible, I just updated the examples to reflect it.
2 participants
No description provided.