Skip to content

Removed os.system in favor of do_shell#628

Merged
kmvanbrunt merged 2 commits intomasterfrom
simplify_edit
Feb 22, 2019
Merged

Removed os.system in favor of do_shell#628
kmvanbrunt merged 2 commits intomasterfrom
simplify_edit

Conversation

@kmvanbrunt
Copy link
Copy Markdown
Member

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 22, 2019

Codecov Report

Merging #628 into master will decrease coverage by 1.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #628     +/-   ##
=========================================
- Coverage   93.21%   92.11%   -1.1%     
=========================================
  Files          11       11             
  Lines        3196     3195      -1     
=========================================
- Hits         2979     2943     -36     
- Misses        217      252     +35
Impacted Files Coverage Δ
cmd2/cmd2.py 93.43% <100%> (-0.8%) ⬇️
cmd2/rl_utils.py 53.84% <0%> (-43.59%) ⬇️
cmd2/clipboard.py 72.22% <0%> (-22.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 086d4db...befeaaf. Read the comment docs.

Copy link
Copy Markdown
Member

@tleonhardt tleonhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok

@kmvanbrunt kmvanbrunt merged commit bb37645 into master Feb 22, 2019
@kmvanbrunt kmvanbrunt deleted the simplify_edit branch February 22, 2019 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants