Pyscript overhaul #630
Pyscript overhaul #630
Conversation
Codecov Report
@@ Coverage Diff @@
## master #630 +/- ##
==========================================
- Coverage 94.13% 94.08% -0.05%
==========================================
Files 10 10
Lines 3101 2957 -144
==========================================
- Hits 2919 2782 -137
+ Misses 182 175 -7
Continue to review full report at Codecov.
|
tleonhardt
left a comment
tleonhardt
left a comment
There was a problem hiding this comment.
Overall it looks good. Please look at my comments.
| @@ -1,3 +0,0 @@ | |||
| # flake8: noqa F821 | |||
There was a problem hiding this comment.
Is deleting the majority of our pyscript unit tests the right thing to do? Or would it be better to convert them to using the other syntax given that is the only supported one now?
There was a problem hiding this comment.
The deleted tests only exercised the ArgparseFunctor stuff.
The remaining interface to pyscript is simple because it does no translation before sending the command to our parser. It is pretty well covered by existing unit tests.
There was a problem hiding this comment.
Maybe take a quick look at code coverage within do_pyscript and pyscript_bridge. But I think your current approach looks OK overall.
|
@kmvanbrunt Would it be reasonable to address #613 in this PR too? |
Removed ability to call commands in
pyscriptas if they were functions (e.gapp.help()) in favor of only supporting onepyscriptinterface. This simplifies future maintenance.This closes #586 since the feature will no longer exist.