Fix bug in with_argument_list decorator #636
Conversation
Codecov Report
@@ Coverage Diff @@
## master #636 +/- ##
==========================================
+ Coverage 94.21% 94.22% +<.01%
==========================================
Files 11 11
Lines 3010 3014 +4
==========================================
+ Hits 2836 2840 +4
Misses 174 174
Continue to review full report at Codecov.
|
|
|
||
| def with_argument_list(func: Callable[[Statement], Optional[bool]], | ||
| preserve_quotes: bool = False) -> Callable[[List], Optional[bool]]: | ||
| def with_argument_list(*args: List[Callable], preserve_quotes: bool = False) -> Callable[[List], Optional[bool]]: |
There was a problem hiding this comment.
I realize this works, but I'm confused. Why is args a list of Callables?
There was a problem hiding this comment.
Here I am making use of the ability to gather all positional arguments into a list, sort of like a varargs in C/C++ combined with the feature that any arguments after that are keyword-only arguments.
There was a problem hiding this comment.
Here is a better and more complete explanation: https://www.digitalocean.com/community/tutorials/how-to-use-args-and-kwargs-in-python-3
Fix bug when the
with_argument_list decoratoris called with the optionalpreserve_quotesargument.This closes #633