Disable commands #643
Disable commands #643
Conversation
Codecov Report
@@ Coverage Diff @@
## master #643 +/- ##
==========================================
+ Coverage 94.23% 94.31% +0.08%
==========================================
Files 11 11
Lines 3017 3060 +43
==========================================
+ Hits 2843 2886 +43
Misses 174 174
Continue to review full report at Codecov.
|
tleonhardt
left a comment
tleonhardt
left a comment
There was a problem hiding this comment.
The following need to be done:
- Add a new example or modify an existing one to show usage of this feature
- Update the Sphinx docs
- Update he Changelog
I like the feature. I’m going to think some more and sleep on certain implementation details.
|
@tleonhardt I added an example and updated the docs and change log. |
Not adding disabled commands to the history when run.
tleonhardt
left a comment
tleonhardt
left a comment
There was a problem hiding this comment.
Things look good. I'd still recommend moving the utility class outside of cmd2.py into another file and making it so that relevant arguments are passed to __init__ and attributes are immutable.
But things look good now.
cmd2/cmd2.py
Outdated
| pass | ||
|
|
||
|
|
||
| class DisabledCommand: |
There was a problem hiding this comment.
Recommend moving to utils.py, having init take two arguments, and using attrs to make both members immutable.
There was a problem hiding this comment.
I changed it to a namedtuple.
Added way to disable/enable individual commands and entire categories of commands.