Encapsulate all usage of colorama within ansi.py #708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes include:
- ansi.py is now the only cmd2 code which depends on colorama
- cmd2 tests no longer rely on colorama
- Added new functions to ansi.py:
- async_alert_str()
- set_title_str
- Added unit test for set_title_str
TODO:
- Refactor async_alert_str so cursor position is passed in and import from rl_utils is no longer required
- Add unit test(s) for async_alert_str
- Refactor FG_COLORS and BG_COLORS in ansi.py to not use constants from colorama
…e readline buffer is passed in This way, the function is independent of readline and can more easily be unit tested
…lumns and added unit tests for it
Codecov Report
@@ Coverage Diff @@
## master #708 +/- ##
==========================================
+ Coverage 95.99% 96.02% +0.02%
==========================================
Files 12 12
Lines 3344 3368 +24
==========================================
+ Hits 3210 3234 +24
Misses 134 134
Continue to review full report at Codecov.
|
kmvanbrunt
approved these changes
Jul 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored
cmd2code and unit tests so that all usage of thecoloramadependency is now limited solely to the ansi.py file.Added two new functions to ansi.py:
async_alert_str()set_title_str()Also added unit tests for these new functions.
This closes #705