Auto completer refactor

CHANGELOG.md

@@ -1,4 +1,8 @@
 ## 0.9.15 (July TBD, 2019)
+* Enhancements
+    * Greatly simplified using argparse-based tab completion. The new interface is a complete overhaul that breaks
+    the previous way of specifying completion and choices functions. See header of [argparse_custom.py](https://github.com/python-cmd2/cmd2/blob/master/cmd2/argparse_custom.py)
+    for more information. 
 * **Renamed Commands Notice**
     * The following commands were renamed in the last release and have been removed in this release
         * `load` - replaced by `run_script`
@@ -9,7 +13,11 @@
 * Breaking Changes
     * Restored `cmd2.Cmd.statement_parser` to be a public attribute (no underscore) 
         * Since it can be useful for creating [post-parsing hooks](https://cmd2.readthedocs.io/en/latest/features/hooks.html#postparsing-hooks)
-
+    * Completely overhauled the interface for adding tab completion to argparse arguments. See enhancements for more details.
+    * `ACArgumentParser` is now called `ArgParser`
+    * Moved `basic_complete` to utils.py
+    * Made optional arguments on the following completer methods keyword-only:
+    `delimiter_complete`, `flag_based_complete`, `index_based_complete`. `path_complete`, `shell_cmd_complete`
 
 ## 0.9.14 (June 29, 2019)
 * Enhancements

CODEOWNERS

@@ -15,12 +15,14 @@
 
 # cmd2 code
 cmd2/__init__.py           @tleonhardt @kotfu
-cmd2/argparse_completer.py @anselor @kmvanbrunt
+cmd2/ansi.py               @kmvanbrunt @tleonhardt
+cmd2/argparse_*.py         @kmvanbrunt
 cmd2/clipboard.py          @tleonhardt
 cmd2/cmd2.py               @tleonhardt @kmvanbrunt @kotfu
 cmd2/constants.py          @kotfu
 cmd2/parsing.py            @kotfu @kmvanbrunt
-cmd2/pyscript_bridge.py    @anselor @kmvanbrunt
+cmd2/plugin.py             @kotfu
+cmd2/pyscript_bridge.py    @kmvanbrunt
 cmd2/rl_utils.py           @kmvanbrunt
 cmd2/transcript.py         @kotfu
 cmd2/utils.py              @tleonhardt @kotfu @kmvanbrunt
@@ -29,23 +31,21 @@ cmd2/utils.py              @tleonhardt @kotfu @kmvanbrunt
 docs/*                  @tleonhardt @kotfu
 
 # Examples
-examples/env*.py        @kotfu
-examples/help*.py       @anselor
-examples/tab_au*.py     @anselor
-examples/tab_co*.py     @kmvanbrunt
+examples/async_printing.py  @kmvanbrunt
+examples/environment.py     @kotfu
+examples/tab_*.py           @kmvanbrunt
 
 # Unit Tests
-tests/pyscript/*        @anselor @kmvanbrunt
-tests/transcripts/*     @kotfu
-tests/__init__.py       @kotfu
-tests/conftest.py       @kotfu @tleonhardt
-tests/test_acar*.py     @anselor
-tests/test_argp*.py     @kotfu
-tests/test_auto*.py     @anselor
-tests/test_comp*.py     @kmvanbrunt
-tests/test_pars*.py     @kotfu
-tests/test_pysc*.py     @anselor
-tests/test_tran*.py     @kotfu
+tests/pyscript/*              @kmvanbrunt
+tests/transcripts/*           @kotfu
+tests/__init__.py             @kotfu
+tests/conftest.py             @kotfu @tleonhardt
+tests/test_argparse.py        @kotfu
+tests/test_argparse_*.py      @kmvanbrunt
+tests/test_comp*.py           @kmvanbrunt
+tests/test_pars*.py           @kotfu
+tests/test_run_pyscript.py    @kmvanbrunt
+tests/test_transcript.py      @kotfu
 
 # Top-level project stuff
 CONTRIBUTING.md         @tleonhardt @kotfu

README.md

@@ -150,8 +150,8 @@ Instructions for implementing each feature follow.
 
     See https://cmd2.readthedocs.io/en/latest/argument_processing.html for more details
 
-    NOTE: `cmd2` also provides the `ACArgumentParser` customization of `argparse.ArgumentParser` for prettier formatting
-    of help and RangeAction type
+    NOTE: `cmd2` also provides the `cmd2.ArgParser` customization of `argparse.ArgumentParser` for prettier formatting
+    of help and error messages.
 
 - `cmd2` applications function like a full-featured shell in many ways (and are cross-platform)
     - Run arbitrary shell commands by preceding them with `!` or `shell`
@@ -182,8 +182,7 @@ Instructions for implementing each feature follow.
     - `delimiter_complete` helper method for tab completion against a list but each match is split on a delimiter 
         - See the [tab_autocompletion.py](https://github.com/python-cmd2/cmd2/blob/master/examples/tab_autocompletion.py) example for a demonstration of how to use this feature
     - `cmd2` in combination with `argparse` also provide several advanced capabilities for automatic tab-completion
-            - See the [tab_autocompletion.py](https://github.com/python-cmd2/cmd2/blob/master/examples/tab_autocompletion.py) and
-            [tab_autocomp_dynamic.py](https://github.com/python-cmd2/cmd2/blob/master/examples/tab_autocomp_dynamic.py) examples for more info
+            - See the [tab_autocompletion.py](https://github.com/python-cmd2/cmd2/blob/master/examples/tab_autocompletion.py) example for more info
 
 - Multi-line commands
 

cmd2/__init__.py

@@ -11,6 +11,7 @@
     pass
 
 from .ansi import style
+from .argparse_custom import ArgParser, CompletionItem
 from .cmd2 import Cmd, Statement, EmptyStatement, categorize
 from .cmd2 import with_argument_list, with_argparser, with_argparser_and_unknown_args, with_category
 from .constants import DEFAULT_SHORTCUTS