Skip to content

Miscellaneous code cleanup#72

Merged
tleonhardt merged 3 commits intomasterfrom
shlex
Mar 12, 2017
Merged

Miscellaneous code cleanup#72
tleonhardt merged 3 commits intomasterfrom
shlex

Conversation

@tleonhardt
Copy link
Copy Markdown
Member

Code cleanup including:

  • Disable PyCharm inspections for a few innocuous warnings, mostly associated with Python 2/3 compatibility
  • Add comments for some classes and functions explaining their purpose
  • Declared some instance members inside init or at class head along with comments
  • Removed unused arguments from a couple methods and dead code associated with them
  • Removed redundant escapes from a few regular expressions

Also fixed a bug in list command when the history was empty.

- Removed some redundant escape charaters in regular expressions
- Removed some some unused arguments from functions and associated dead code
- Added some lines to suppress innocuous PyCharm warnings
- Added some comments to explain the purpose of some of the custom classes and functions
- Added declaration of some attributes within __init__ for clarity
@tleonhardt tleonhardt added this to the 0.7.1 milestone Mar 12, 2017
@tleonhardt tleonhardt self-assigned this Mar 12, 2017
@tleonhardt tleonhardt merged commit e1dab4e into master Mar 12, 2017
@tleonhardt tleonhardt deleted the shlex branch March 12, 2017 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant