Added sigint protection while entering/leaving cmd2 and Python interactive shells #730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tleonhardt
requested changes
Jul 18, 2019
| return arg_decorator | ||
|
|
||
|
|
||
| class _SavedReadlineSettings: |
Member
There was a problem hiding this comment.
Does this code belong in rl_utils.py?
Member
Author
There was a problem hiding this comment.
Since this class is only used in cmd2.py, I'm OK leaving it.
tleonhardt
approved these changes
Jul 18, 2019
tleonhardt
approved these changes
Jul 19, 2019
Member
tleonhardt
left a comment
tleonhardt
left a comment
There was a problem hiding this comment.
Should the CHANGELOG be updated in some way to reflect this change?
Member
Author
|
@tleonhardt No need for CHANGELOG updates on this |
Codecov Report
@@ Coverage Diff @@
## master #730 +/- ##
==========================================
+ Coverage 97.15% 97.21% +0.05%
==========================================
Files 13 13
Lines 3376 3406 +30
==========================================
+ Hits 3280 3311 +31
+ Misses 96 95 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #686
This should prevent getting into mixed environment states by allowing environment changes to occur atomically.