Skip to content

ipy fix #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tleonhardt merged 2 commits into from
Oct 31, 2019
Merged

ipy fix #794

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eee9a5e
Only removing ipy from cmd2 instances instead of the class when use_i…
kmvanbrunt Oct 30, 2019
8056c5b
Updated change log
kmvanbrunt Oct 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,7 @@
## 0.9.20 (TBD, 2019)
* Bug Fixes
* Fixed bug where setting `use_ipython` to False removed ipy command from the entire `cmd2.Cmd` class instead of
just the instance being created
* Enhancements
* Send all startup script paths to run_script. Previously we didn't do this if the file was empty, but that
showed no record of the run_script command in history.
Expand Down
4 changes: 2 additions & 2 deletions cmd2/cmd2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,10 +368,10 @@ def __init__(self, completekey: str = 'tab', stdin=None, stdout=None, *,
:param shortcuts: dictionary containing shortcuts for commands. If not supplied, then defaults to
constants.DEFAULT_SHORTCUTS.
"""
# If use_ipython is False, make sure the do_ipy() method doesn't exit
# If use_ipython is False, make sure the ipy command isn't available in this instance
if not use_ipython:
try:
del Cmd.do_ipy
self.do_ipy = None
Copy link
Member

@tleonhardt tleonhardt Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a better way to deal with it, good call

except AttributeError:
pass

Expand Down