Fixing unit tests that were causing problems on the test servers#806
Merged
kmvanbrunt merged 2 commits intomasterfrom Nov 13, 2019
Merged
Fixing unit tests that were causing problems on the test servers#806kmvanbrunt merged 2 commits intomasterfrom
kmvanbrunt merged 2 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #806 +/- ##
=========================================
+ Coverage 97.28% 97.3% +0.02%
=========================================
Files 14 14
Lines 3493 3493
=========================================
+ Hits 3398 3399 +1
+ Misses 95 94 -1
Continue to review full report at Codecov.
|
tleonhardt
previously approved these changes
Nov 13, 2019
tests/test_utils.py
Outdated
| # Put the new process into a separate group so signals sent to it won't interfere with this process | ||
| if sys.platform.startswith('win'): | ||
| command = 'dir' | ||
| command = 'timeout -t -1 /nobreak' |
Member
There was a problem hiding this comment.
Fantastic work fixing some unreliable tests which have been giving us grief for a long time!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #797