Fix a dependency version requirement which was too restrictive #956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quired bleeding edge for no good reason
kmvanbrunt
approved these changes
Jul 14, 2020
Codecov Report
@@ Coverage Diff @@
## master #956 +/- ##
=======================================
Coverage 97.65% 97.65%
=======================================
Files 19 19
Lines 4188 4188
=======================================
Hits 4090 4090
Misses 98 98 Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a dependency version requirement which was too restrictive and required bleeding edge for no good reason.
The 1.2.0 release was put out with a dependency on version 1.7.0 or newer of
importlib-metadatawhen running on versions of Python earlier than 3.8. However, that version was only released on June 26, 2020 which makes it extremely bleeding edge: https://pypi.org/project/importlib-metadata/#historyThis PR relaxes the dependency to >= 1.6.0 which was released on March 27, 2020 so it is still rather new, but not as painfully bleeding-edge. The point of this is to ease compatibility issues with recent Linux distros and such.