Skip to content

Initial checkin of Modular Command definitions as a plugin. #943 #957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
anselor wants to merge 6 commits into from
Closed

Initial checkin of Modular Command definitions as a plugin. #943 #957

anselor wants to merge 6 commits into from

Conversation

@anselor
Copy link
Contributor

@anselor anselor commented Jul 16, 2020

No description provided.

@anselor anselor requested a review from tleonhardt July 16, 2020 22:06
@anselor anselor requested review from kmvanbrunt and kotfu as code owners July 16, 2020 22:06
@anselor anselor changed the title Initial checkin of Modular Command definitions as a plugin. Initial checkin of Modular Command definitions as a plugin. #943 Jul 16, 2020
@anselor anselor force-pushed the modular_commands_plugin branch 3 times, most recently from 48081c9 to a7d482d Compare July 16, 2020 23:21
@codecov
Copy link

codecov bot commented Jul 16, 2020 •
edited
Loading

Codecov Report

Merging #957 into master will decrease coverage by 0.07%.
The diff coverage is 96.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #957      +/-   ##
==========================================
- Coverage   97.71%   97.63%   -0.08%     
==========================================
  Files          17       24       +7     
  Lines        4155     4395     +240     
==========================================
+ Hits         4060     4291     +231     
- Misses         95      104       +9
Impacted Files Coverage Δ
plugins/ext_test/cmd2_ext_test/cmd2_ext_test.py 91.30% <ø> (ø)
plugins/template/cmd2_myplugin/myplugin.py 92.59% <ø> (ø)
...ins/modular_cmd/cmd2_modular_cmds/modular_mixin.py 94.44% <94.44%> (ø)
cmd2/__init__.py 100.00% <100.00%> (+8.33%) ⬆️
cmd2/cmd2.py 96.90% <100.00%> (+<0.01%) ⬆️
plugins/ext_test/cmd2_ext_test/__init__.py 100.00% <100.00%> (ø)
plugins/modular_cmd/cmd2_modular_cmds/__init__.py 100.00% <100.00%> (ø)
...odular_cmd/cmd2_modular_cmds/command_definition.py 100.00% <100.00%> (ø)
plugins/template/cmd2_myplugin/__init__.py 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2df28cb...a8d2490. Read the comment docs.

@anselor anselor force-pushed the modular_commands_plugin branch 3 times, most recently from 7a4157b to 2c150fe Compare July 17, 2020 20:42
@anselor anselor force-pushed the modular_commands_plugin branch from 555b5e8 to a8535d7 Compare July 18, 2020 20:43
@anselor anselor closed this Aug 4, 2020
@anselor
Copy link
Contributor Author

anselor commented Aug 4, 2020

Accepting #961 instead.

@anselor anselor deleted the modular_commands_plugin branch August 4, 2020 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tleonhardt tleonhardt Awaiting requested review from tleonhardt

@kmvanbrunt kmvanbrunt Awaiting requested review from kmvanbrunt

@kotfu kotfu Awaiting requested review from kotfu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@anselor