Skip to content

Fixed hook documentation #959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kmvanbrunt merged 1 commit into from
Jul 17, 2020
Merged

Fixed hook documentation #959

kmvanbrunt merged 1 commit into from
Jul 17, 2020

Conversation

@kmvanbrunt
Copy link
Member

@kmvanbrunt kmvanbrunt commented Jul 17, 2020

Closes #958

@kmvanbrunt kmvanbrunt added this to the 1.2.2 milestone Jul 17, 2020
@kmvanbrunt kmvanbrunt self-assigned this Jul 17, 2020
tleonhardt
tleonhardt approved these changes Jul 17, 2020
View reviewed changes
@codecov
Copy link

codecov bot commented Jul 17, 2020 •
edited
Loading

Codecov Report

Merging #959 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #959      +/-   ##
==========================================
+ Coverage   97.71%   97.73%   +0.02%     
==========================================
  Files          17       17              
  Lines        4155     4155              
==========================================
+ Hits         4060     4061       +1     
+ Misses         95       94       -1
Impacted Files Coverage Δ
cmd2/cmd2.py 96.89% <100.00%> (ø)
cmd2/utils.py 98.25% <0.00%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa92771...b0b825d. Read the comment docs.

@kmvanbrunt kmvanbrunt merged commit 2df28cb into master Jul 17, 2020
@kmvanbrunt kmvanbrunt deleted the doc_fix branch July 17, 2020 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tleonhardt tleonhardt tleonhardt approved these changes

@kotfu kotfu Awaiting requested review from kotfu

Assignees

@kmvanbrunt kmvanbrunt

Labels

documentation

Projects

None yet

Milestone

1.2.2

Development

Successfully merging this pull request may close these issues.

Registering a preloop hook without return type hint throws an error

3 participants

@kmvanbrunt @tleonhardt