Skip to content

Conversation

@anselor
Copy link
Contributor

@anselor anselor commented Aug 4, 2020

Consolidated both with_argparsers implementations.

Resolves #962

implementation as an option to with_argparser instead.
@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #963 into master will decrease coverage by 0.05%.
The diff coverage is 62.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #963      +/-   ##
==========================================
- Coverage   97.83%   97.78%   -0.06%     
==========================================
  Files          22       22              
  Lines        4487     4465      -22     
==========================================
- Hits         4390     4366      -24     
- Misses         97       99       +2     
Impacted Files Coverage Δ
cmd2/decorators.py 97.16% <62.50%> (-2.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c0bdad...9ffc9a1. Read the comment docs.

@anselor anselor merged commit 2c99c0d into master Aug 4, 2020
@anselor anselor deleted the consolidate_with_argparsers branch August 4, 2020 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate with_argparser_and_unknown_args and add with_unknown parameter to with_argparser

3 participants