add ab08nz function to support complex state-space systems#96
Merged
roryyorke merged 10 commits intopython-control:masterfrom Apr 12, 2020
Merged
add ab08nz function to support complex state-space systems#96roryyorke merged 10 commits intopython-control:masterfrom
roryyorke merged 10 commits intopython-control:masterfrom
Conversation
Collaborator
|
Please add one or more unit tests here as discussed in python-control/python-control#376 |
Contributor
Author
|
I've written a simple test for both
|
Collaborator
|
I sent you a PR lytex#1. If you accept, this PR here will be updated. See also https://github.com/bnavigator/Slycot/tree/complex-pyf for Travis CI results. |
roryyorke
requested changes
Apr 11, 2020
Collaborator
roryyorke
left a comment
roryyorke
left a comment
There was a problem hiding this comment.
Thanks! Two docstring changes requested.
roryyorke
approved these changes
Apr 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add ab08nz function to support regular pencil for complex state-space systems