Upgrade To 3.9 and Poetry #1582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Migrates package manager to poetry, and updates python version to 3.9. Some packages are updated where needed. Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
Adds python dotenv to emulate the default .env file loading behavior from pipenv. Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
HassanAbouelela
added
a: dependencies
HassanAbouelela
requested review from
Akarys42,
Den4200,
MarkKoz,
SebastiaanZ and
jb3
as code owners
Updates the Dockerfile, pre-commit, CI, and documentation to reflect the new dependency manager. Dockerfile is also updated to 3.9. Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
HassanAbouelela
force-pushed
the
39-poetry
branch
from
52b7d1a to
f9068d5
Compare
Updates Pipfile and pipenv lock file to poetry equivalents in CODEOWNERS. Signed-off-by: Hassan Abouelela <hassan@hassanamr.com>
HassanAbouelela
force-pushed
the
39-poetry
branch
from
f9068d5 to
8187ab2
Compare
ChrisLovering
approved these changes
May 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bumps the python version to 3.9 (.5 in docker), and switches from pipenv to poetry as the package manager. The vote to switch to poetry is here.
Changes
This is a good time to bump python-discord/sir-lancebot#623 which was stalled by the same dependency this PR was.