Team 17 by SharpBit · Pull Request #8 · python-discord/code-jam-1

SharpBit · 2018-03-23T01:07:10Z

Teammate: @Volcyy

glhf

Fix Pipfile dependencies

gdude2002 · 2018-03-23T09:36:46Z

bot/cogs/snakes.py

        :param name: Optional, the name of the snake to get information for - omit for a random snake
        :return: A dict containing information on a snake
        """
+        pass


pass is not required if there's a docstring.

gdude2002 · 2018-03-23T09:36:55Z

bot/cogs/snakes.py

        :param ctx: Context object passed from discord.py
        :param name: Optional, the name of the snake to get information for - omit for a random snake
        """
+        pass


pass is not required if there's a docstring.

gdude2002 · 2018-03-23T09:37:30Z

run.py

+except FileNotFoundError:
+    print('No token found.')
+else:
+    bot.run(token)


No, this whole block is incorrect. Don't run the bot this way. Read over the doc/ folder in the repository again, it explains exactly how you should be doing this.

gdude2002 · 2018-03-23T09:38:23Z

Your build is currently failing.

./run.py:2:1: F401 'os' imported but unused
./run.py:3:1: I100 Import statements are in the wrong order. 'import json' should be before 'import os'
./bot/cogs/snakes.py:4:1: F401 'bs4.BeautifulSoup' imported but unused
./bot/cogs/snakes.py:4:1: I201 Missing newline between import groups. 'from bs4 import BeautifulSoup' is identified as Third Party and 'from typing import Any, Dict' is identified as Stdlib.
./bot/cogs/snakes.py:5:1: I201 Missing newline between import groups. 'from discord.ext.commands import AutoShardedBot, Context, command' is identified as Third Party and 'from bs4 import BeautifulSoup' is identified as Third Party.

- Fix the way the bot is run to match with the docs (including removing `config.json` from the `.gitignore` file - Create the bot's session and response from the info source - update the info source and functions to easily get info - add dependencies (bs4 and lxml)

- still have to remove html tags - fix image url to actually work - move image to the embed's image function - region picture to thumbnail - more info

[UPDATE] Ignored a silly rule from flake8.

So far these don't return an image: - bullsnake - ringneck snake - puff adder

- still ussues with the snek map image url - see the comments in L14-16 in bot/cogs/snakes.py - add command aliases

- until we get a fix - proper css selector - correct link

- if apostrophe: remove it # used in `children's python`

gdude2002 · 2018-03-25T11:06:01Z

.gitignore

@@ -1,4 +1,4 @@
-# Byte-compiled / optimized / DLL files
+ Byte-compiled / optimized / DLL files


No, this should be a comment.

gdude2002 · 2018-03-25T11:06:42Z

bot/cogs/logging.py

+        log.info('--------------')
        log.info("Bot connected!")

+        self.bot.session = ClientSession(loop=self.bot.loop)


Don't do that, this should be done in the cog itself and set on self.

gdude2002 · 2018-03-25T11:07:18Z

bot/cogs/logging.py

+            for i, snek in enumerate(self.bot.sneks):
+                self.bot.sneks[i] = snek.replace('\u200b', '').replace('\ufeff', '')
+
+        log.info('Snakes loaded.')


This is the logging cog. If you need to do stuff on_ready, do it in your cog.

you can make two on_ready events in two different files?

You sure can!

what order will the bot perform the actions in?

No idea. You shouldn't rely on that.

gdude2002 · 2018-03-25T11:08:34Z

bot/cogs/snakes.py

        :return: A dict containing information on a snake
        """
+        if name:
+            if name not in self.bot.sneks:


This, again, should be an attribute on your cog, not the bot.

gdude2002 · 2018-03-25T11:10:07Z

run.py

 bot.load_extension("bot.cogs.snakes")

-bot.run(os.environ.get("BOT_TOKEN"))
+bot.run(os.environ.get('BOT_TOKEN'))


Haha, come on, no need to change the quote marks.

i use single quotes, just that i accidentally did the config.json stuff before so when i changed it back i naturally used single quotes

gdude2002 · 2018-03-25T11:10:19Z

run.py

        ">>>", ">>", ">"
    ),  # Order matters (and so do commas)
-    activity=Game(name="Help: bot.help()"),
+    activity=Game(name="with snekky sneks"),


Probably a bit user-unfriendly, but it's fine in this case. :P

still mentionable /shrug

- the stupid image that changes divs - that causes some commands for snakes to be broken (IndexError) - some snakes still don't show with an image (cut-off html?)

- remove unnecessary import - added it to on_ready in seperate cog - cog attribute, not bot attribute - fix accidental `.gitignore` change - tic tac toe uses python emoji - update tic tac toe board

less clutter in the actual command

This reverts commit 9edf8c9.

loops through the possible divs

- this site's html is like anti-webscrape - no one cares about the eastern brown snake - i put `for x in range(1, 7)`, but for some reason it's not doing the 1? - only 1 issue so far but as i already said, no one cares about the eastern brown snake so screw that

jb3 · 2018-03-25T21:47:06Z

bot/cogs/snakes.py

    def __init__(self, bot: AutoShardedBot):
        self.bot = bot

+    PYTHON_INFO = {


This probably shouldn't be a class variable, but a module variable declared above class declaration.

jb3 · 2018-03-25T21:47:57Z

bot/cogs/snakes.py

+        return em
+
+    def format_info(self, data, color=discord.Color.green()):
+        '''Formats the info with the given data.'''


""" are preferred in docstrings over '''

Not required, but some documentation for the parameters would be nice, maybe some type annotations at the least to say what data should be.

jb3 · 2018-03-25T21:50:59Z

bot/cogs/snakes.py

-    # Any additional commands can be placed here. Be creative, but keep it to a reasonable amount!
+    @command(aliases=['getsnekfact', 'snekfact()', 'get_snek_fact()'])
+    async def snekfact(self, ctx: Context):
+        '''


Again, """ are preferred over '''

SharpBit added 2 commits March 22, 2018 21:06

just add some pass stuff

b312786

glhf

Merge pull request #1 from discord-python/master

31fe5d8

Fix Pipfile dependencies

gdude2002 changed the title ~~just add some pass stuff~~ Team 17 Mar 23, 2018

SharpBit added 5 commits March 22, 2018 22:01

some startup stuff

f92cf5e

Merge branch 'master' of https://github.com/SharpBit/code-jam-1

d04759c

fix bs4 req

91cfb2d

remove that

6dd7aef

right thing to run

c865044

gdude2002 reviewed Mar 23, 2018

View reviewed changes

SharpBit and others added 12 commits March 23, 2018 18:43

rough estimate of what it should look like

80273f6

- still have to remove html tags - fix image url to actually work - move image to the embed's image function - region picture to thumbnail - more info

@Pikuhana can u do something

36ace30

Merge pull request #2 from discord-python/master

9816692

[UPDATE] Ignored a silly rule from flake8.

Use image from OGP tag, remove unused methods.

2d743c8

test

b77b7fe

Merge branch 'master' of https://github.com/SharpBit/code-jam-1

49f5251

image (most work) and description

f915d90

So far these don't return an image: - bullsnake - ringneck snake - puff adder

Attach URL and location map.

a552543

did you know command

3234d57

- still ussues with the snek map image url - see the comments in L14-16 in bot/cogs/snakes.py - add command aliases

remove map image for now

3f56b6c

- until we get a fix - proper css selector - correct link

if python: send language

dfd3175

- if apostrophe: remove it # used in `children's python`

gdude2002 suggested changes Mar 25, 2018

View reviewed changes

jchristgit and others added 5 commits March 25, 2018 13:20

Fix location map image URL.

0ff0f42

Still more bugs...

ddc6e4e

- the stupid image that changes divs - that causes some commands for snakes to be broken (IndexError) - some snakes still don't show with an image (cut-off html?)

Added a TicTacToe game stub.

9edf8c9

fix some requests and travis stuff

97e0e9d

- remove unnecessary import - added it to on_ready in seperate cog - cog attribute, not bot attribute - fix accidental `.gitignore` change - tic tac toe uses python emoji - update tic tac toe board

redo the bot.get python

adafa48

less clutter in the actual command

jchristgit and others added 6 commits March 25, 2018 18:35

Revert "Added a TicTacToe game stub."

7033463

This reverts commit 9edf8c9.

completely remove

cca57c4

fix flake8 linting import order

3f91775

map region works all the time!

b712a24

loops through the possible divs

fix flake8

256d4e1

jb3 suggested changes Mar 25, 2018

View reviewed changes

fix requested changes

0854cb1

		@@ -1,4 +1,4 @@
		# Byte-compiled / optimized / DLL files
		Byte-compiled / optimized / DLL files

Uh oh!

Conversation

SharpBit commented Mar 23, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gdude2002 commented Mar 23, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

SharpBit commented Mar 23, 2018 •

edited

Loading