Skip to content

Conversation

@nathanjmcdougall
Copy link
Contributor

[x] Add tests for the change. In general, aim for full test coverage at the Python level. Rust tests are optional.
[ ] Add any appropriate documentation.
[x] Add a summary of changes to CHANGELOG.rst.
[x] Add your name to AUTHORS.rst.
[x] Run just full-check.

Resolves #272

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 16, 2025

CodSpeed Performance Report

Merging #276 will not alter performance

Comparing nathanjmcdougall:maint/add-deprecation-for-NamespacePackageEncountered (f996d29) with main (f397742)

Summary

✅ 26 untouched
⏩ 23 skipped1

Footnotes

  1. 23 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Copy link
Collaborator

@seddonym seddonym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

Couple of minor suggestions before we merge.

(Also you probably want to rebase off the latest main branch as there's a conflict.)

@seddonym seddonym merged commit 3c0aad7 into python-grimp:main Dec 19, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NamespacePackageEncountered exception docstring needs revisiting?

2 participants