Skip to content

Conversation

@dofine
Copy link
Contributor

@dofine dofine commented Jul 4, 2023

Propose zh_CN translation for "thousand" to be "千"

Fixes #126

Changes proposed in this pull request:

  • Make zh_CN localization for "thousand" to "千", though according to General rules for writing numerals in public texts of GB/T 15835-2011, it's not right to write "4,000" as "4.0千". But however I think it's better than "4.0 thousand". Hope more zh_CN users could give their opinions.

Add zh_CN translation for "thousand"
@hugovk hugovk added the changelog: Added For new features label Jul 4, 2023
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Merging #127 (c6eaf06) into main (72315f6) will decrease coverage by 1.63%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
- Coverage   99.18%   97.55%   -1.63%     
==========================================
  Files           9        9              
  Lines         737      737              
==========================================
- Hits          731      719      -12     
- Misses          6       18      +12     
Flag Coverage Δ
macos-latest 97.55% <ø> (ø)
ubuntu-latest ?
windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@hugovk hugovk merged commit 2643d37 into python-humanize:main Aug 16, 2023
@hugovk hugovk changed the title Propose zh_CN translation for "thousand" to be "千" Translate "thousand" to "千" for zh_CN Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: Added For new features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add localization for thousand in zh_CN

2 participants