Fix DeprecationWarning: Plural value must be an integer, got float #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
=======================================
Coverage 99.19% 99.19%
=======================================
Files 9 9
Lines 746 747 +1
=======================================
+ Hits 740 741 +1
Misses 6 6
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
hugovk
requested changes
Oct 18, 2023
Member
hugovk
left a comment
hugovk
left a comment
There was a problem hiding this comment.
Thanks for the PR! A couple of suggestions.
Fixed an error where a float value given in _ngettext generated errors when expecting integer value
Fixed an error where there was a DeprecationWarning upon using a float, when an integer was expected
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
dansarpong
force-pushed
the
fix/pluralInteger
branch
from
5cfb80e to
fe227a6
Compare
hugovk
approved these changes
Oct 19, 2023
Member
hugovk
left a comment
hugovk
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
hugovk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #106
Changes proposed in this pull request: