Skip to content

Conversation

@merwok
Copy link
Contributor

@merwok merwok commented Apr 1, 2025

  • fix number units translations
  • use proper decimal separator

msgstr "e"

#: src/humanize/number.py:178
#: src/humanize/number.py:183
Copy link
Contributor Author

@merwok merwok Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my own projects, I tend to save filenames but not line numbers to PO files, to avoid such diff churn.
What do you think of changing the update script in another PR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't make translations myself, so if they're not useful I'll take your word for it and a PR is welcome :)

Copy link
Contributor Author

@merwok merwok Apr 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either the line numbers get outdated, so they are useless and get ignored, or they create churn in the history (which I could just accept but…)

So personally I find the filenames useful to be able to look up the context (source strings and even context lines from pgettext are not always enough), I tend to dislike the line numbers.

But you could open a ticket and ping translators to see their experience!

@hugovk hugovk added the changelog: Fixed For any bug fixes label Apr 1, 2025
@codecov
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.49%. Comparing base (09d081f) to head (4167864).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #248   +/-   ##
=======================================
  Coverage   99.49%   99.49%           
=======================================
  Files          11       11           
  Lines         796      798    +2     
=======================================
+ Hits          792      794    +2     
  Misses          4        4           
Flag Coverage Δ
macos-latest 97.74% <100.00%> (+<0.01%) ⬆️
ubuntu-latest 97.74% <100.00%> (+<0.01%) ⬆️
windows-latest 95.73% <0.00%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hugovk hugovk merged commit f772e59 into python-humanize:main Apr 1, 2025
34 of 35 checks passed
@hugovk
Copy link
Member

hugovk commented Apr 1, 2025

Merci beaucoup !

@merwok merwok deleted the feat/improve-fr branch April 1, 2025 20:57
@hugovk hugovk changed the title Improvements for French translation Improve French translation Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: Fixed For any bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants