Skip to content

Conversation

@hugovk
Copy link
Member

@hugovk hugovk commented Jun 21, 2022

Fixes #24.

Changes proposed in this pull request:

  • Before:
    • humanize.intcomma(12345.111, ndigits=0) == "12,345.111"
  • After:
    • humanize.intcomma(12345.111, ndigits=0) == "12,345"

@hugovk hugovk added bug Something isn't working changelog: Fixed For any bug fixes labels Jun 21, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2022

Codecov Report

Merging #26 (03863fe) into main (29d37fb) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #26   +/-   ##
=======================================
  Coverage   99.09%   99.09%           
=======================================
  Files           9        9           
  Lines         666      666           
=======================================
  Hits          660      660           
  Misses          6        6           
Flag Coverage Δ
macos-latest 97.89% <100.00%> (ø)
ubuntu-latest 97.89% <100.00%> (ø)
windows-latest 97.59% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/test_number.py 100.00% <ø> (ø)
src/humanize/number.py 96.89% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29d37fb...03863fe. Read the comment docs.

@hugovk hugovk merged commit 0e6ef5a into python-humanize:main Jun 21, 2022
@hugovk hugovk deleted the fix-intcomma-ndigits-0 branch June 21, 2022 07:30
@hugovk hugovk changed the title Fix intcomma with ndigits=0 Fix intcomma with ndigits=0 Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working changelog: Fixed For any bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

humanize.intcomma(num, ndigits=0) does not behave as expected

2 participants