-
-
Notifications
You must be signed in to change notification settings - Fork 80
Improve precisedelta to better support rounding and float values.
#39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #39 +/- ##
==========================================
- Coverage 99.13% 97.41% -1.73%
==========================================
Files 9 9
Lines 690 695 +5
==========================================
- Hits 684 677 -7
- Misses 6 18 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
e2f2dad to
9ff98f7
Compare
|
(Force-pushed to clean up the commit history, since it was getting a bit long. 😅 Let me know if you'd like me to squash it down even more!) This PR now includes one of the commits from #19, to fix the root cause of #14. Thank you, @eldipa! 💜 I've also updated the description (#39 (comment)) to reflect all of the test cases that this PR adds and fixes. |
|
Thanks both! |
Fixes #14.
Fixes #20.
Changes proposed in this pull request
floatvalues inprecisedelta.Test cases added to
test_precisedelta_custom_formatTest cases added to
test_precisedelta_multiple_units