Skip to content

Conversation

@vishket
Copy link
Contributor

@vishket vishket commented Jul 8, 2022

Fixes #12

Changes proposed in this pull request:

  • Support intword for negative numbers
  • Update corresponding test test_intword

@vishket vishket marked this pull request as ready for review July 8, 2022 11:17
@codecov-commenter
Copy link

codecov-commenter commented Jul 8, 2022

Codecov Report

Merging #41 (4c76d35) into main (5dc4b82) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #41   +/-   ##
=======================================
  Coverage   99.12%   99.13%           
=======================================
  Files           9        9           
  Lines         686      690    +4     
=======================================
+ Hits          680      684    +4     
  Misses          6        6           
Flag Coverage Δ
macos-latest 97.39% <100.00%> (+0.01%) ⬆️
ubuntu-latest 97.39% <100.00%> (+0.01%) ⬆️
windows-latest 97.10% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/test_number.py 100.00% <ø> (ø)
src/humanize/number.py 96.99% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5dc4b82...4c76d35. Read the comment docs.

@hugovk hugovk added changelog: Fixed For any bug fixes labels Jul 8, 2022
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A suggestion :)

@hugovk
Copy link
Member

hugovk commented Jul 8, 2022

Hmm, looks like my suggestion didn't post, will try again!

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take 2!

@hugovk
Copy link
Member

hugovk commented Jul 11, 2022

Thank you @vishket for the PR and @carterbox for the review!

@hugovk hugovk merged commit e705e43 into python-humanize:main Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog: Fixed For any bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

intword with negative numbers

4 participants