Change entrypoint name to simply be black#39
Merged
ccordoba12 merged 1 commit intopython-lsp:masterfrom Dec 14, 2023
Merged
Conversation
Member
|
@haplo, I think this one is good to go, right? |
ccordoba12
approved these changes
Dec 14, 2023
Member
ccordoba12
left a comment
ccordoba12
left a comment
There was a problem hiding this comment.
Thanks for your contribution @chantera!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames the entrypoint name
pylsp_blacktoblack.Currently,
pylsp.plugins.black.enabled: falsecannot disable the plugin becausepluggy.PluginManagerused inpylsp.config.config.Configregisters a plugin using its entrypoint name [link].Thus, the plugin is registered as
pylsp_blackand can be disabled bypylsp.plugins.pylsp_black.enabled: false.This is confusing because we have to use
pylsp.plugins.pylsp_black.enabledwhen disabling the plugin while usingpylsp.plugins.black.*to give settings to black.This issue does not occur in python-lsp-ruff because it uses
ruffas its entrypoint name [link].Fixes #41.