Update mypy and fix issues#680
Merged
Secrus merged 12 commits intoJun 10, 2023
Merged
Conversation
Secrus
reviewed
Dec 1, 2022
deb08e2 to
63b7414
Compare
CodSpeed Performance ReportMerging #680 Summary
|
Collaborator
|
@bryanforbes could you update to the latest version of |
Contributor
Author
|
@Secrus this is ready to go |
Secrus
approved these changes
Jun 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List
This upgrades
mypyto 0.991 and fixes the errors associated with it. I've also removed themypycheck frompre-commitand added a type checking step during unit testing. This requires runningpoetry installtwice to remove the type checking dependencies to ensure that there are no runtime dependencies on the type checking libraries (liketyping_extensions). Another option would be to change thepre-commitconfig to usemypyviapoetry, remove the third-partypre-commitPR hook, and add a Github action that invokespre-commitwith the properpoetry install. That can be done as a separate PR, though.