-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add complex text support #1682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add complex text support #1682
Conversation
b82ec14 to
5bd6ce4
Compare
|
Thanks for the contribution. This is something that have been requested several times. From a quick look at this I've got several concerns:
|
|
Also, please don't rebase PRs when we're reviewing them. |
|
Raqm depends on HarfBuzz, which is not packaged for Precise. For the other point, would providing fallback code for when Raqm is missing (that does essentially what the old code is doing) an acceptable compromise? |
|
I think I'd want fallback code to be comfortable merging this. I'd also want to update the scripts in the |
877e0f9 to
07d96e0
Compare
|
I am working on fallback code in case that Raqm is missing, so it will use the old code. |
|
This provide the documentation, testing and fallback code. |
|
Travis CI didn't build. I checked .travis.yml on https://lint.travis-ci.org/ and it said:
|
|
The failure is due to merge conflict, so I will rebase this after you finish reviewing the code. |
|
Go ahead and fix the merge conflicts so we can get good test runs on this. |
6468cf7 to
9dd39e9
Compare
This pull request adds support for languages that require complex text layout. We are using the Raqm library, that wraps FriBidi (for bidirectional text support) and HarfBuzz (for text shaping), and does proper BiDi and script itemization: https://github.com/HOST-Oman/libraqm This should fix python-pillow#1089.
719890a to
0c9f04f
Compare
4e584ca to
9d806ee
Compare
c419212 to
b15f362
Compare
|
I have a problem in testing file I have added. I run it locally and it is ok, but I can't find why it fails during travis-ci buliding. Even I can't reproduce the issue locally. |
|
Any progress with this? @ShamsaHamed can you upgrade this to Pillow 3.4.2? Then I will try to find and fix problems with the tests, if possible (this feature is needed for me :) |
|
Closed, merged with #2576 Thanks to everyone who worked on this, I think it's a valuable addition to the library. |
|
Thanks to you for your efforts and sorry for my absence to complete the work. I have a problem with my device. |
This pull request adds support for languages that require complex text layout.
We are using the Raqm library, that wraps FriBidi (for bidirectional
text support) and HarfBuzz (for text shaping), and does proper BiDi and script
itemization:
https://github.com/HOST-Oman/libraqm
This should fix #1089.